Skip to content

[pull] master from r0adkll:master #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[pull] master from r0adkll:master #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b21a12
update default build-tools version to 33.0.0
Jan 12, 2024
f30bdd3
Merge pull request #85 from hamz4k/bump_default_build_tools_version
r0adkll Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Then copy the contents of the `.txt` file to your GH secrets

## ENV: `BUILD_TOOLS_VERSION`

**Optional:** You can manually specify a version of build-tools to use. We use `29.0.3` by default.
**Optional:** You can manually specify a version of build-tools to use. We use `34.0.0` by default.

## Outputs

Expand Down Expand Up @@ -68,8 +68,8 @@ steps:
keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }}
keyPassword: ${{ secrets.KEY_PASSWORD }}
env:
# override default build-tools version (29.0.3) -- optional
BUILD_TOOLS_VERSION: "30.0.2"
# override default build-tools version (33.0.0) -- optional
BUILD_TOOLS_VERSION: "34.0.0"

# Example use of `signedReleaseFile` output -- not needed
- uses: actions/upload-artifact@v2
Expand Down
2 changes: 1 addition & 1 deletion lib/signing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function signApkFile(apkFile, signingKeyFile, alias, keyStorePassword, keyPasswo
return __awaiter(this, void 0, void 0, function* () {
core.debug("Zipaligning APK file");
// Find zipalign executable
const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '29.0.3';
const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '33.0.0';
const androidHome = process.env.ANDROID_HOME;
const buildTools = path.join(androidHome, `build-tools/${buildToolsVersion}`);
if (!fs.existsSync(buildTools)) {
Expand Down
2 changes: 1 addition & 1 deletion src/signing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export async function signApkFile(
core.debug("Zipaligning APK file");

// Find zipalign executable
const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '29.0.3';
const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '33.0.0';
const androidHome = process.env.ANDROID_HOME;
const buildTools = path.join(androidHome!, `build-tools/${buildToolsVersion}`);
if (!fs.existsSync(buildTools)) {
Expand Down