Skip to content

Conversation

eminence
Copy link
Contributor

This option causes the sending side to not send any data and instead immeditally send an EOF. This can be useful when you are only interested in sending data in one direction.

Closes #10

@eminence
Copy link
Contributor Author

bikeshed: the --close name was picked based on this comment but maybe there's a better name for this argument.

@n0bot n0bot bot added this to iroh Jul 28, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Jul 28, 2025
@rklaehn
Copy link
Contributor

rklaehn commented Jul 28, 2025

Hm, --close is confusing I think. --one-way is better, but it also is not clear which way, given that the listener could send or receive data. How about something like --recv-only or --send-only?

@dignifiedquire
Copy link
Contributor

maybe --once ?

@eminence
Copy link
Contributor Author

--once also feels confusing to me.

Is --close-stdin any clearer?

--recv-only is also nice

@rklaehn
Copy link
Contributor

rklaehn commented Jul 29, 2025

I think --recv-only is nicest. It leaves the door open for --send-only if we ever need it, and can be used on both sides if ever needed.

This option causes the sending side to not send any data and instead
immeditally send an EOF.  This can be useful when you are only
interested in sending data in one direction.

Closes n0-computer#10
@eminence
Copy link
Contributor Author

Any other suggested changes on this PR?

@dignifiedquire dignifiedquire merged commit 9339195 into n0-computer:main Sep 11, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Sep 11, 2025
@dignifiedquire
Copy link
Contributor

Thanks, sorry for the delay

@eminence
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

dumbpipe connect does not close on EOF

3 participants