feat!: Allow configuring the downloader when creating a blobs protocol handler #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handler we don't allow passing in the entire downloader, but all config options.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/76/docs/iroh_blobs/ Last updated: 2025-05-12T13:23:05Z |
…is properly applied. - downloader handle has the config - downloader handle gets an Arc<Inner>
# Conflicts: # src/net_protocol.rs
Member
|
semver check indicates breaking changes, should go in the PR description! |
matheus23
approved these changes
Mar 14, 2025
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
👍 besides me wondering about the Downloader struct wrapping.
Collaborator
|
@rklaehn what's the state of this PR? |
Frando
changed the title
Member
|
Merged main, fixed the merge commits, and filled in the Breaking changes section in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow configuring the downloader when creating a blobs protocol handler
we don't allow passing in the entire downloader, but all config options.
Breaking Changes
iroh_blobs::downloader::Downloadernow takes aconfig: Configargument instead ofconcurrency_limits: ConcurrencyLimits, retry_config: RetryConfig.Confighas two public fieldconcurrency_limitsandretry_config, so the migration is straightforward.Otherwise there's only additions (a new method
downloader_configon theBlobsconstructor).Notes & open questions
Change checklist