tests: Add network test with many nodes #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/65/docs/iroh_gossip/ Last updated: 2025-05-20T12:06:51Z |
Simulation reportLast updated: 2025-05-20T12:07:07Z |
Frando
force-pushed
the
Frando/feat-net-shutdown
branch
from
d956b94 to
549bec9
Compare
Frando
force-pushed
the
Frando/test-net-big
branch
from
a893707 to
130d5dc
Compare
Frando
force-pushed
the
Frando/feat-net-shutdown
branch
from
549bec9 to
b1b5ee7
Compare
Frando
force-pushed
the
Frando/test-net-big
branch
from
130d5dc to
9fc90bd
Compare
Frando
force-pushed
the
Frando/feat-net-shutdown
branch
from
b1b5ee7 to
b4abbd4
Compare
Frando
force-pushed
the
Frando/test-net-big
branch
from
9fc90bd to
9d0a324
Compare
Frando
force-pushed
the
Frando/test-net-big
branch
from
9d0a324 to
cfefa65
Compare
| } | ||
|
|
||
| #[tokio::test(flavor = "multi_thread")] | ||
| async fn gossip_net_big() -> TestResult { |
There was a problem hiding this comment.
This is a large enough test to merit some docs on its own. Could you describe first the setup (topology, number of nodes, churn, loss, etc, - you know the deal - plus listing what the env parameters are and what they mean in the context of the test) and then what it's asserting happens or does not happen?
| .map(|x| x.parse().unwrap()) | ||
| .unwrap_or(10000); | ||
| let timeout = Duration::from_millis(timeout_ms); | ||
| info!("recv timeout: {timeout:?}"); |
There was a problem hiding this comment.
is this supposed to have logs?I don't see anything initializing the logger and I ran this with RUST_LOG=debug, --nocapture too and got nothing
There was a problem hiding this comment.
I readded the logging. I guess I removed it on accident inbetween.
Frando
force-pushed
the
Frando/test-net-big
branch
from
cfefa65 to
a80bf1b
Compare
Frando
force-pushed
the
Frando/feat-net-shutdown
branch
from
b4abbd4 to
1c521b9
Compare
Frando
added a commit
that referenced
this pull request
May 19, 2025
This adds a large integration test that bootstraps a swarm with many nodes and lets each node broadcast some messages. The test runs with 100 nodes and 2 messages per node. On my machine I ran it a couple of times with 1000 nodes in release mode. It completes fine, but takes a while in debug mode, thus limited to 100 nodes for now to not overwhelm CI.
Frando
force-pushed
the
Frando/test-net-big
branch
from
a80bf1b to
51218d1
Compare
This adds a large integration test that bootstraps a swarm with many nodes and lets each node broadcast some messages. The test runs with 100 nodes and 2 messages per node. On my machine I ran it a couple of times with 1000 nodes in release mode. It completes fine, but takes a while in debug mode, thus limited to 100 nodes for now to not overwhelm CI.
Frando
force-pushed
the
Frando/test-net-big
branch
from
51218d1 to
d1ec336
Compare
It isn't. I will need to dig in why it fails on cross and times out on windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #53 and #64
This adds a large integration test that bootstraps a swarm with many nodes and lets each node broadcast some messages.
The test runs with 100 nodes and 2 messages per node.
On my machine I ran it a couple of times with 1000 nodes in release mode, completes fine, but takes a while in debug mode, thus limited to 100 nodes for now to not overwhelm CI.
Breaking Changes
Notes & open questions
Change checklist