[WIP] refactor: remove add_node_addr API #3338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently |
flub
reviewed
Jun 3, 2025
| let recv = self.inner.subscribe(); | ||
| BroadcastStream::new(recv).map_err(|BroadcastStreamRecvError::Lagged(n)| Lagged { val: n }) | ||
| pub(crate) fn subscribe(&self) -> impl Stream<Item = Option<DiscoveryItem>> { | ||
| self.inner.watch().stream() |
There was a problem hiding this comment.
IIUC this is a quite big behaviour change: previously you'd have a reasonable chance of seeing all discovered items, now you only get a single one. Especially the ConcurrentDiscovery this could be an issue if multiple discovery services find something at the same time you'll miss one address.
flub
reviewed
Jun 3, 2025
| /// [`MdnsDiscovery`]: crate::discovery::mdns::MdnsDiscovery | ||
| /// [`StaticProvider`]: crate::discovery::static_provider::StaticProvider | ||
| pub fn discovery_stream(&self) -> impl Stream<Item = Result<DiscoveryItem, Lagged>> { | ||
| pub fn discovery_stream(&self) -> impl Stream<Item = Option<DiscoveryItem>> { |
There was a problem hiding this comment.
Just from looking at the signature change I think the old API was more correct here as well?
|
this doesn't work as I would like it to.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting to fix #3329, and trying to cleanup discovery interactions while at it
Breaking Changes
TODO