fix(iroh): Only clear last_call_me_maybe when the best addr became invalid
#3415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3415/docs/iroh/ Last updated: 2025-07-29T19:14:11Z |
matheus23
commented
Jul 29, 2025
Comment on lines
+127
to
+131
| event!( | ||
| target: "iroh::_events::udp::best_ipv4", | ||
| Level::DEBUG, | ||
| ?best_ipv4, | ||
| ); |
There was a problem hiding this comment.
I thought it would be fitting to promote these to be events.
FWIW, we also have "new connection type" events that contain the send addr, but this additionally prints whether we think this is an outdated, valid or unconfirmed address.
ramfox
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug introduced in #3400
We used to only reset
last_call_me_maybetoNonewhen the best address was cleared. The above PR accidentally changed that to always reset.Change checklist