-
Notifications
You must be signed in to change notification settings - Fork 55
Moved hot key handling and clipboard impl to crossterm. #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In raw mode, the cursor won't go back to line beginning when '\n' is printed. A '\r' would mannually reset the error message.
I need someone with Windows device to test whether Ctrl+C will quit the default compiled program, thanks! You need to:
|
> If the function succeeds, the return value is nonzero.
Having tested it on my friend's Windows 10 PC with Windows Terminal. The above process works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested building and running this PR for Termux (Android) and I can confirm that it also prevents the problem of terminal output breaking after pushing Ctrl + C to stop sending on Termux.
So how do I reproduce this with the original sendme? Run it on windows and then hit control-c? Ah, never mind. It is in the issue. |
Windows may or may not be affected by the original issue, I just want to check if the PR works on Windows. Never mind, I have tested it on my friend's Windows 10 PC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Closes #94.
However, this brings more dependencies and is expected to longer compilation time.
The buggy
read_key
impl inconsole
will keep the terminal in raw mode, where subsequent commands in shell won't see echo.What's more, Ctrl+C used by tokio is tricky on Windows, so I am not aware how to trigger that correctly in new clipboard handling block.