Skip to content

refactor(editor): Migrate remaining workflow object usages#28327

Draft
autologie wants to merge 10 commits intomigrate-workflow-object-usagesfrom
migrate-remaining-workflow-object-usages
Draft

refactor(editor): Migrate remaining workflow object usages#28327
autologie wants to merge 10 commits intomigrate-workflow-object-usagesfrom
migrate-remaining-workflow-object-usages

Conversation

@autologie
Copy link
Copy Markdown
Contributor

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Bundle Report

Changes will decrease total bundle size by 32.67kB (-0.07%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
editor-ui-esm 45.4MB -32.67kB (-0.07%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/constants-*.js -2.23kB 3.14MB -0.07%
assets/index-*.js 385 bytes 1.31MB 0.03%
assets/users.store-*.js -47 bytes 1.05MB -0.0%
assets/core-*.js -1.44kB 612.91kB -0.23%
assets/useCanvasMapping-*.js 62 bytes 462.6kB 0.01%
assets/InstanceAiView-*.js -12.03kB 285.18kB -4.05%
assets/InstanceAiView-*.css -5.23kB 155.67kB -3.25%
assets/router-*.js -54 bytes 117.75kB -0.05%
assets/useCanvasOperations-*.js 373 bytes 95.76kB 0.39%
assets/SettingsSso-*.js -7.26kB 87.31kB -7.67%
assets/NodeSettings-*.js 339 bytes 84.84kB 0.4%
assets/CanvasRunWorkflowButton-*.js 100 bytes 84.58kB 0.12%
assets/ProjectSettings-*.js -920 bytes 73.1kB -1.24%
assets/CreditWarningBanner-*.js -1.64kB 64.4kB -2.48%
assets/SettingsSso-*.css -985 bytes 32.89kB -2.91%
assets/SettingsUsersView-*.js -513 bytes 32.02kB -1.58%
assets/ProjectRoleView-*.js -727 bytes 31.9kB -2.23%
assets/AppSidebar-*.js -26 bytes 31.82kB -0.08%
assets/usePushConnection-*.js 73 bytes 31.1kB 0.24%
assets/MainSidebarHeader-*.js 172 bytes 18.45kB 0.94%
assets/SettingsPersonalView-*.js -501 bytes 16.61kB -2.93%
assets/ProjectRoleView-*.css -137 bytes 2.31kB -5.6%
assets/InstanceAiLayout-*.js -444 bytes 1.03kB -30.04%

Files in assets/useCanvasMapping-*.js:

  • ./src/features/shared/contextMenu/composables/useContextMenuItems.ts → Total Size: 7.97kB

  • ./src/features/workflows/canvas/components/elements/nodes/render-types/parts/CanvasNodeSettingsIcons.vue → Total Size: 425 bytes

Files in assets/useCanvasOperations-*.js:

  • ./src/app/composables/useCanvasOperations.ts → Total Size: 73.85kB

Files in assets/NodeSettings-*.js:

  • ./src/features/ndv/panel/components/NDVSubConnections.vue → Total Size: 358 bytes

Files in assets/CanvasRunWorkflowButton-*.js:

  • ./src/app/composables/useWorkflowExtraction.ts → Total Size: 12.92kB

Files in assets/usePushConnection-*.js:

  • ./src/app/composables/usePushConnection/handlers/executionFinished.ts → Total Size: 12.83kB

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
50477 2 50475 2
View the top 2 failed test(s) by shortest run time
ExecutionPersistence deleteUnsaved should soft-delete with backdated `deletedAt` when pruning is enabled
Stack Traces | 0.001s run time
Error: expect(received).toBeLessThanOrEqual(expected)

Expected: <= 1775824651732
Received:    1775824651733
    at Object.<anonymous> (.../executions/__tests__/execution-persistence.test.ts:231:32)
    at processTicksAndRejections (node:internal/process/task_queues:104:5)
n8n node API coverage every spec endpoint is tracked in the manifest
Stack Traces | 0.004s run time
Error: Custom message:
  API endpoint(s) in the spec are not in the manifest.
Add each to: .../nodes/N8n/n8n-api-coverage.json

Missing:
  - GET /insights/summary

Example entry:
  "GET /insights/summary": {
  "status": "gap"
}

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 3

- Array []
+ Array [
+   "GET /insights/summary",
+ ]
    at Object.<anonymous> (.../N8n/test/N8n.api-coverage.test.ts:111:5)
    at Promise.then.completed (.../n8n/node_modules/.pnpm/jest-circus@29.6..../jest-circus/build/utils.js:300:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../n8n/node_modules/.pnpm/jest-circus@29.6..../jest-circus/build/utils.js:233:10)
    at _callCircusTest (.../n8n/node_modules/.pnpm/jest-circus@29.6..../jest-circus/build/run.js:315:40)
    at processTicksAndRejections (node:internal/process/task_queues:104:5)
    at _runTest (.../n8n/node_modules/.pnpm/jest-circus@29.6..../jest-circus/build/run.js:251:3)
    at _runTestsForDescribeBlock (.../n8n/node_modules/.pnpm/jest-circus@29.6..../jest-circus/build/run.js:125:9)
    at _runTestsForDescribeBlock (.../n8n/node_modules/.pnpm/jest-circus@29.6..../jest-circus/build/run.js:120:9)
    at run (.../n8n/node_modules/.pnpm/jest-circus@29.6..../jest-circus/build/run.js:70:3)
    at runAndTransformResultsToJestFormat (.../n8n/node_modules/.pnpm/jest-circus@29.6..../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../n8n/node_modules/.pnpm/jest-circus@29.6..../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../n8n/node_modules/.pnpm/jest-runner@29.6..../jest-runner/build/runTest.js:367:16)
    at runTest (.../n8n/node_modules/.pnpm/jest-runner@29.6..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../n8n/node_modules/.pnpm/jest-runner@29.6..../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Performance Comparison

Comparing currentlatest master14-day baseline

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-n8n 1269.76 MB 1269.76 MB 1269.76 MB (σ 0.00) +0.0% +0.0%
docker-image-size-runners 386.00 MB 386.00 MB 387.50 MB (σ 3.00) +0.0% -0.4%

Memory consumption baseline with starter plan resources

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-heap-used-baseline 113.31 MB 114.53 MB 113.09 MB (σ 1.15) -1.1% +0.2%
How to read this table
  • Current: This PR's value (or latest master if PR perf tests haven't run)
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 14-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: ✅ within 1σ | ⚠️ 1-2σ | 🔴 >2σ regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant