Fix BOLT 11 spec compliance: skip unknown fallback address versions#81
Merged
Conversation
Owner
|
Hi @jklein24, first of all thank you for the fix. I just need you to sign the commit so I can proceed with the merge. |
Per BOLT 11 spec, readers "MUST skip over `f` fields that use an unknown `version`" and "versions 19-31 will be ignored by readers." Previously, FallbackAddressTaggedField.FromBitReader threw an exception for unknown address versions. Now it returns null, which the existing TaggedFieldList already handles by skipping the field. Changes: - Return null instead of throwing for unknown versions (1-16, 19-31) - Update return type to FallbackAddressTaggedField? - Add tests for unknown version handling - Add Assert.NotNull to existing tests for nullable return type Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
Done! |
nGoline
approved these changes
Feb 5, 2026
nGoline
left a comment
nGoline
left a comment
Owner
There was a problem hiding this comment.
Changes are sound, tests are written, LGTM!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per BOLT 11 spec, readers "MUST skip over
ffields that use an unknownversion" and "versions 19-31 will be ignored by readers."https://github.com/lightning/bolts/blob/master/11-payment-encoding.md#rationale-2
The context is that Spark embeds a fallback spark address with version 31 which should be ignored by lightning implementations as per the BOLT11 spec, but instead nlightning is throwing an error when parsing a spark lightning invoice.
Previously, FallbackAddressTaggedField.FromBitReader threw an exception for unknown address versions. Now it returns null, which the existing TaggedFieldList already handles by skipping the field.
Changes: