Improve LED pulsing with natural breathing effect #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the linear step-based LED pulsing with a smooth sinusoidal (cosine-based) animation to simulate a natural breathing rhythm. This makes the LED transitions softer and more organic. The pulse cycle duration is configurable via PULSING_STEPS and PULSING_RATE.
- Increased pulsing smoothness by raising PULSING_STEPS to 15 - Increased pulsing frequency by reducing PULSING_RATE to 100ms - Replaced abstract method placeholders with proper NotImplementedError to ensure subclasses must implement do_set and do_show - Prepares a more natural and responsive LED pulsing experience
Refined the LED pulsing effect to achieve a smoother, more natural rhythm. Set PULSING_RATE to 0.05 seconds and PULSING_STEPS to 30, resulting in a full pulse cycle (fade in and out) of approximately 3 seconds. This provides a calmer and more lifelike breathing effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the linear step-based LED pulsing with a smooth sinusoidal (cosine-based) animation to simulate a natural breathing rhythm. This makes the LED transitions softer and more organic. The pulse cycle duration is configurable via PULSING_STEPS and PULSING_RATE.