-
-
Notifications
You must be signed in to change notification settings - Fork 7
Addtional UTF-8 unit tests #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all green now. Your fix did make it. 🥳
Thank you! 👏🏻 👏🏻 👏🏻
Description
Add Test for Valid UTF-8 2, 3 and 4 bytes.
Add Test for Invalid UTF-8 2, 3 and 4 bytes.
Add Test for valid ASCII Range.
Add Test UTF-8 max code point and beyond code point.
Add Test for ASCII with emoji.
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: