Replace ConfigPlan status-based approval with Nautobot Approval Workflow - #1119
Draft
nkallergis wants to merge 2 commits into
Draft
Replace ConfigPlan status-based approval with Nautobot Approval Workflow#1119nkallergis wants to merge 2 commits into
nkallergis wants to merge 2 commits into
Conversation
ConfigPlan now inherits ApprovableModelMixin; new plans automatically trigger a Pending workflow on creation, and Deploy Config Plans (E3025) gates on the workflow being Approved rather than on the legacy "Approved" / "Not Approved" Status values. A migration seeds the default "Config Plan Approval" workflow definition plus three groups (architect / approver / operator) and their permissions; existing pending plans are force-re-approved on upgrade. Admins can amend or delete the workflow definition to customize or disable approvals. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
The Python 3.10 / Nautobot 3.0.0 CI matrix runs a stricter pylint that flags the inline `from nautobot.extras.models.approvals import ApprovalWorkflowDefinition` inside the test method as `import-outside-toplevel` (C0415), causing the lint step to fail. Move the import to the file header to keep the matrix green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigPlan now inherits ApprovableModelMixin; new plans automatically trigger a Pending workflow on creation, and Deploy Config Plans (E3025) gates on the workflow being Approved rather than on the legacy "Approved" / "Not Approved" Status values. A migration seeds the default "Config Plan Approval" workflow definition plus three groups (architect / approver / operator) and their permissions; existing pending plans are force-re-approved on upgrade. Admins can amend or delete the workflow definition to customize or disable approvals.