This repository was archived by the owner on Jun 29, 2026. It is now read-only.
Repository navigation
fix: StegClient implements InferenceClientInterface - #1
Merged
Merged
Conversation
The StegClient façade exposed all methods of InferenceClientInterface (complete, stream, isHealthy, listModels) with identical signatures, but did not declare 'implements InferenceClientInterface'. As a result, ndrstmr/steg-bundle's DI alias of InferenceClientInterface::class to a StegClient instance threw a TypeError whenever a consumer typehinted the interface in their constructor. Adds the missing 'implements' declaration. Pure type-system change, no behavior modification. Adds StegClientTest covering polymorphism and delegation.
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StegClient façade exposed all methods of InferenceClientInterface (complete, stream, isHealthy, listModels) with identical signatures, but did not declare 'implements InferenceClientInterface'. As a result, ndrstmr/steg-bundle's DI alias of InferenceClientInterface::class to a StegClient instance threw a TypeError whenever a consumer typehinted the interface in their constructor.
Adds the missing 'implements' declaration. Pure type-system change, no behavior modification. Adds StegClientTest covering polymorphism and delegation.