-
Notifications
You must be signed in to change notification settings - Fork 38
Fix benchmarks with regards to jsonwebtoken performance #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think you could also update the benchmarks, so we could also close #507 |
I had to regenerated the |
@Gobd we've done a bit of overhaul on the way we run and capture the benchmark results. When you get a chance, would you mind doing this work on top of what's in master now? I chose to replace cronometro with mitata due to issues with running is cross-platform. |
Sure let me work on that |
Done! Now you can see jsonwebtoken's performance is much more reasonable so no one panics and thinks they need to switch ASAP. I mean they do need to switch to using the keys correctly ASAP to fix their performance. I have switched to fast-jwt anyways because it was almost no work and is faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for this!
Closes #536
The benchmark results in the readme will also need updating but not sure if you wanted me to do that or run them yourselves. The results are exactly like the linked issue suggests, 50x better performance after this change.
I also added HS256 to the benchmarks because why not, and also that's what I use.