More fixes

[mscottx88]

Closes #28

[ryan-roemer]

This is looking pretty good! Just minor suggestions mostly.

Big thing is the binary search vs. linear progression for character splitting. Maybe I'm missing something? Let's chat if there's an optimization and whether to do it here or in follow on work

[mscottx88]

Thanks sir! I'll add the character explicit split. The binary search thing is a bit esoteric to me as well, honestly.

…

On Tue, Jul 15, 2025, 7:14 PM Ryan Roemer ***@***.***> wrote: ***@***.**** commented on this pull request. This is looking pretty good! Just minor suggestions mostly. Big thing is the binary search vs. linear progression for character splitting. Maybe I'm missing something? Let's chat if there's an optimization and whether to do it here or in follow on work — Reply to this email directly, view it on GitHub <#29 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7IYMLJF7N7SUACHJNBXOL3IWYOZAVCNFSM6AAAAACBSRLQXOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMRSHA4DIMRVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mscottx88]

I further analyzed the binary search when it comes to calculating where the overlap should begin. The performance is pretty dramatic.

[simoneb]

As discussed with @mscottx88, we're still waiting for a round of reviews on this and a bit of discussion.