-
Notifications
You must be signed in to change notification settings - Fork 4
Fix/revert pr224 #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/revert pr224 #304
Conversation
@ilteoood can you take a look at this, as you were part of the conversation in the PR that this reverts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The revert LGTM, but why package.json changed while the lock didn't?
Thanks for the feedback. Added commits for:
I was looking at the 224 as a reference and missed the fact that it included |
@simoneb I'm okay to revert whichever way you think makes the most sense. The advantage of accepting this PR is that it adds a test that shows that assumption fails. If you want to revert with GitHub, I have no problem making a new PR to add that test. Whatever works best is fine. #224 makes an invalid assumption about naming (changing I think #224 was trying to implement TSON path generation, similar to So I created #305 to try to get the discussion out of PR threads and into one, more visible issue. |
Closes #294
FooBARBaz
(fails)FooBARBaz
to example schemaOutstanding:
-p
really supposed to do foroas2tson
andoas2json
?openapi-transformer-toolkit
support generating path specs? (discussion in: feat: generate schema from paths OpenAPI prop #230)-p
have a place inoas2tson
oroas2json
?-
as replacement for/
in paths, etc.?oas2tson
be refactored to align better with other commands -- and should that be the first next step?{ "foo": 1, "bar": "barbar" }
becomes{ foo: 1, bar: "barbar" }
If so, oas2tson = oas2json + convert to .js may be easier. (I tried searching, but of course all the answers are "JSON.parse()".)