Support for infobar screens present in devices like StreamDeck Neo#253
Support for infobar screens present in devices like StreamDeck Neo#253evilbug wants to merge 3 commits intonekename:mainfrom
Conversation
|
Hello and thanks for the contribution. @mcbridet What do you think of this approach? Does it align with what you had in mind? Do you have more progress than this implementation? Also, although I know this is the default functionality in Elgato's software, I'm not convinced that I want to have the clock as an action in the Starter Pack. Not only will it not work with most people's devices, leading to confusion, but in addition it's something I won't be able to test as I don't own the device. So, please, create a separate plugin for the clock action; this also has the added benefit of not adding all these dependencies to the Starter Pack, and facilitating the addition of new actions. I'm not sure that I like the naming of the new Finally, you seem to have made many changes to the code that aren't related to the content of the PR. There's some indentation changes, unnecessary semantic changes, and so on. Please go through and undo all of those changes. |
|
Hi! Thanks for your response!
I think you should reconsider this, as there are use cases where the screen gets frozen with the latest info screen frame. This is very annoying, because if you used the device in windows/osx with a clock, the last hour:minute available is frozen in this screen, confusing the user a lot. I think OpenDeck should provide at least a base functionality to blackout the InfoScreen to avoid this unwanted behaviour. So I just considered instead of this blackout useless feature, just replicate the official Elgato software that already includes the clock as a base plugin.
Alright! I can take a look and find a better solution. But this is a new controller, different than others as it has no input available, it is just a picture renderer.
Ok! I can review and remove all this extra changes. |
|
Thanks for your very nice response. To be honest, I'd prefer just the blackout - users would have to manually add the clock action anyway, and this just simplifies the code needed in OpenDeck itself, which is my main goal these days. I don't actually mind the new controller that much. Was just wondering what Tim has to say regarding his implementation. Thanks for removing the unnecessary changes - I'm seeing, for example, some debug code left in, and some comments in some Ibero-Romance language (probably just Spanish), etc. Repository policy is that signed commits are necessary, so maybe squash your commits, sign the squashed commit then force push |
Added support for Infobar screens on the StreamDeck Neo.
If a Neo device is detected, a new Infobar row appears on the layout:
You can drag Infobar-enabled plugins to this new area. By default, I have included a demo plugin that displays the date and clock, as shown in the screenshot.
Preflight checklist