Preprocessing features for re-saving mcorr results in C order#346
Open
ethanbb wants to merge 11 commits intonel-lab:masterfrom
Open
Preprocessing features for re-saving mcorr results in C order#346ethanbb wants to merge 11 commits intonel-lab:masterfrom
ethanbb wants to merge 11 commits intonel-lab:masterfrom
Conversation
…oupParams objects)
… save_c_order_mmap_parallel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds some new parameters that can be specified under the
"preprocessing"top-level key of params (rather than"main") to do extra steps while re-saving the movie in C-order. (This is distinct from the "main.preprocess" namespace for the preprocessing done inCNMF.fit- I couldn't think of a better name, but we could potentially still change it to avoid confusion.These new parameters are supported under "preprocessing":
border_pixels: controls setting border pixels to 0 (as in theborder_to_0argument tosave_memmap). Value can be:left,right,top, andbottom, plusz_topandz_bottomfor 3D movies, for unequal bordersNone, to infer borders directly from motion correction results (only supported if input is an mcorr mesmerize item)add_to_movie: constant to add to the movie (default is 0.0001, matchingsave_memmap)highpass_cutoffandhighpass_order: Sethighpass_cutoffto a float > 0 to high-pass filter the data during transposition to C-order. This is implemented using a zero-phase Butterworth filter of orderhighpass_order(default 4).