Fix connection acquisition timeout #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
… version settings, and modify Dockerfile for .NET SDK 9.0
…xceptionManager; update LoadBalancer to include driver context in connection acquisition.
| Bookmarks bookmarks, | ||
| bool forceAuth) | ||
| { | ||
| return await AcquireConnectionInternalAsync(mode, database, sessionConfig, bookmarks, forceAuth) |
There was a problem hiding this comment.
Is it the case that because AcquireConnectionInternalAsync does not observe a cancellationToken that the underlying operations might continue running after the await timesout? The timeout is effectively only impacting the awaiting task? The ConnectionAcquisition timeout is still being used on several steps lower down the stack (), so I'm wondering if the CancelationToken should be passed down the layers that way enforcing the timeout across all operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes the removal of deprecated severity property.