Clarify vector rules and bug fixes #685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid vectors: - dbtype.Vector[T] where T is int8/16/32/64, float32/64, or their aliases - Type aliases: type MyVec = dbtype.Vector[int8] - Element aliases: type MyInt = int8; dbtype.Vector[MyInt] - Pointers: *dbtype.Vector[T] Invalid vectors: - New types wrapping vectors: type MyVec dbtype.Vector[int8] - New element types: type MyInt int8; dbtype.Vector[MyInt] Check regular slices serialize as lists, not vectors
StephenCathcart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DRIVERS-115
dbtype.Vector[T](whereTis in setint8/16/32/64,float32/64), aliases ofT, aliases ofVector, and pointers to vectors.type MyI8 int8; dbtype.Vector[MyI8]{...}.List, e.g.type MyVec dbtype.Vector[int8]; MyVec{1,2,3}.Fixed
VectorElementby tightening constraint; added pointer-to-vector support.