Skip to content

Vector type helpers (w/ new package structure) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: 6.x
Choose a base branch
from

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Jun 25, 2025

Requires driver version 6 to be released to PyPI and targeted first.

@robsdedude robsdedude changed the title Vector endian swap helper (w/ new package structure) Vector type helpers (w/ new package structure) Jul 21, 2025
@robsdedude robsdedude marked this pull request as ready for review July 21, 2025 16:24
// =================

#[pyfunction]
pub(super) fn vec_f64_from_native<'py>(data: Bound<'py, PyAny>) -> PyResult<Bound<'py, PyBytes>> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this is sound with no-GIL Python!

Copy link
Contributor

@RichardIrons-neo4j RichardIrons-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as a pair.

This way, the input does not actually provide a size hint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants