Skip to content

revert optional tags in paremeterRef #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

revert optional tags in paremeterRef #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b10ed
revert optional tags
henderiw Oct 13, 2023
db12d88
added make generate/manifest
henderiw Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion config/crd/bases/workload.nephio.org_nfdeployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ spec:
type: object
type: array
parametersRefs:
description: ParametersRefs defines addiitonal KRM parmeter references
description: ParametersRefs defines addiitonal KRM parameter references
the nf depends upon
items:
properties:
Expand All @@ -265,6 +265,9 @@ spec:
name:
description: Name of the target resource
type: string
required:
- apiVersion
- kind
type: object
type: array
provider:
Expand Down
6 changes: 3 additions & 3 deletions nf_deployments/v1alpha1/nf_deployment_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@ type NFDeploymentSpec struct {

type ObjectReference struct {
// APIVersion of the target resources
APIVersion string `yaml:"apiVersion,omitempty" json:"apiVersion,omitempty"`
APIVersion string `yaml:"apiVersion" json:"apiVersion"`

// Kind of the target resources
Kind string `yaml:"kind,omitempty" json:"kind,omitempty"`
Kind string `yaml:"kind" json:"kind"`

// Name of the target resource
// +optional
Name *string `yaml:"name" json:"name"`
Name *string `yaml:"name,omitempty" json:"name,omitempty"`

// Note: Namespace is not allowed; the namespace
// must match the namespace of the PackageVariantSet resource
Expand Down