fix: replace require('fs') with ESM import in e2e build tests#3284
Merged
kamilmysliwiec merged 2 commits intov12.0.0from Mar 11, 2026
Merged
fix: replace require('fs') with ESM import in e2e build tests#3284kamilmysliwiec merged 2 commits intov12.0.0from
require('fs') with ESM import in e2e build tests#3284kamilmysliwiec merged 2 commits intov12.0.0from
Conversation
12 tasks
Co-authored-by: kamilmysliwiec <23244943+kamilmysliwiec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from PR #3280 on major release changes
fix: replace Mar 11, 2026
require('fs') with ESM import in e2e build tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/e2e/build.command.e2e-spec.tsruns under ESM ("type": "module"), whererequireis not defined. BothcleanDist()functions usedconst fs = require('fs')inline, causing them to throw at runtime.Changes
import * as fs from 'fs'to the test fileconst fs = require('fs')from bothcleanDist()functions🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.