fix(swc): fail build on type errors with type check#3319
Open
maruthang wants to merge 1 commit intonestjs:masterfrom
Open
fix(swc): fail build on type errors with type check#3319maruthang wants to merge 1 commit intonestjs:masterfrom
maruthang wants to merge 1 commit intonestjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When running
nest build -b swc --type-check, type errors are detected and printed to the console, but the build process still exits with code 0 (success). This happens becauseprocess.exit(1)is called insiderunOnce, which terminates the process before the error can propagate back to the caller. The spinner always shows success, andSwcCompiler.runproceeds with compilation despite type errors.Issue Number: #2646
What is the new behavior?
Type errors now cause the build to fail properly with exit code 1. The
process.exit(1)call inrunOncehas been replaced with a thrownError, which propagates naturally:runOncethrows,runcatches the error and fails the spinner, the promise rejects,SwcCompiler.runskips compilation, andBuildAction.handlecatches the rejection and exits with code 1.Does this PR introduce a breaking change?
Other information
lib/compiler/swc/type-checker-host.ts: Replacedprocess.exit(1)withthrow new Error(...)and added try/catch aroundrunOnceto fail the spinner on error before re-throwing.test/lib/compiler/swc/type-checker-host.spec.ts: Added 4 regression tests covering both success and failure paths forrunandrunOnce.