fix(info): add missing space in os version display#3321
Open
yogeshwaran-c wants to merge 1 commit intonestjs:masterfrom
Open
fix(info): add missing space in os version display#3321yogeshwaran-c wants to merge 1 commit intonestjs:masterfrom
yogeshwaran-c wants to merge 1 commit intonestjs:masterfrom
Conversation
The chalk-to-ansis migration changed multi-argument chalk.blue() to string concatenation but omitted the space that chalk auto-inserted between arguments, resulting in output like "macOS24.3.0" instead of "macOS 24.3.0".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
nest infocommand displays the OS version without a space between the OS name and the kernel release number, e.g.macOS24.3.0orWindows10.0.26200instead ofmacOS 24.3.0orWindows 10.0.26200.This was introduced during the chalk-to-ansis migration (commit 101081a). The original chalk code used multi-argument
chalk.blue(osName(...), release()), where chalk auto-inserted a space between arguments. The migration converted this to string concatenationblue(osName(...) + release())but omitted the space.What is the new behavior?
The OS version is now displayed with a space:
macOS 24.3.0,Windows 10.0.26200,Linux 6.1.0, etc.Does this PR introduce a breaking change?
Other information
Added a unit test that verifies the OS version output contains a space between the name and the release number.