fix(generate): use selected project name for specFileSuffix lookup#3325
Open
yogeshwaran-c wants to merge 1 commit intonestjs:masterfrom
Open
fix(generate): use selected project name for specFileSuffix lookup#3325yogeshwaran-c wants to merge 1 commit intonestjs:masterfrom
yogeshwaran-c wants to merge 1 commit intonestjs:masterfrom
Conversation
When a non-default project is selected during `nest generate`, the `getSpecFileSuffix` call was incorrectly using `appName` (the original CLI input) instead of `selectedProjectName` (the user's interactive selection). This caused per-project `specFileSuffix` configuration to be ignored, falling back to global config instead. The adjacent `shouldGenerateSpec` and `shouldGenerateFlat` calls both correctly use `selectedProjectName` -- this aligns `getSpecFileSuffix` with the same pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When a user runs
nest generatein a monorepo project and is prompted to select a project (because no--projectflag was provided), thegetSpecFileSuffixcall incorrectly usesappName(the original CLI input, which is empty/falsy at this point) instead ofselectedProjectName(the project the user just selected from the interactive prompt).This means that per-project
specFileSuffixconfiguration innest-cli.jsonis silently ignored when a project is interactively selected, and the global default is used instead.Example config where this matters:
{ "projects": { "my-app": { "sourceRoot": "apps/my-app/src", "generateOptions": { "specFileSuffix": "test" } } } }Running
nest generate service fooand selectingmy-appfrom the prompt would generatefoo.spec.tsinstead of the expectedfoo.test.ts.What is the new behavior?
getSpecFileSuffixnow receivesselectedProjectName— consistent with the adjacentshouldGenerateSpecandshouldGenerateFlatcalls that already correctly useselectedProjectName.The one-line fix (line 123 of
actions/generate.action.ts):Additional context
This bug was introduced in #1968 when the
specFileSuffixfeature was added. TheshouldGenerateSpecandshouldGenerateFlatcalls were already usingselectedProjectName, butgetSpecFileSuffixwas mistakenly wired toappName.