Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2a29753
fix(testing): add fallback option to file type validator
Yasir-Rafique Jun 3, 2025
aacc931
fix(testing): added unit test for file type validation
Yasir-Rafique Jun 3, 2025
09300c0
fix(e2e): ensure correct file path and log diagnostics
Yasir-Rafique Jun 3, 2025
14e2cbe
fix(e2e): removed path.join
Yasir-Rafique Jun 3, 2025
e9582ee
fix(e2e): removed path.resolve
Yasir-Rafique Jun 4, 2025
14a1f01
fix(testing): removed deep chain to test
Yasir-Rafique Jun 4, 2025
01deba8
fix(testing): removed custom test cases
Yasir-Rafique Jun 4, 2025
5a3fecb
Merge remote-tracking branch 'upstream/master' into fix/file-type-val…
Yasir-Rafique Jun 4, 2025
7460596
fix: regenerate package-lock.json after merge conflict
Yasir-Rafique Jun 4, 2025
3605e79
fix: downgrade type/node to resolve conflict
Yasir-Rafique Jun 4, 2025
957d707
Merge remote-tracking branch 'upstream/master' into fix/file-type-val…
Yasir-Rafique Jun 4, 2025
bb7cdb0
chore: remove accidental redis dependency
Yasir-Rafique Jul 1, 2025
34efb2c
Merge remote-tracking branch 'upstream/master' into fix/file-type-val…
Yasir-Rafique Jul 1, 2025
bf22e9e
fix(lint): resolve prettier formatting issue
Yasir-Rafique Jul 1, 2025
90497bd
fix: resolved package.json conflict with upstream/master
Yasir-Rafique Jul 1, 2025
feb2a92
fix(core): Ensure compatibility with latest NestJS core
Yasir-Rafique Jul 1, 2025
229ea41
Merge branch 'fix/file-type-validator-compatibility' of https://githu…
Yasir-Rafique Jul 1, 2025
0b904b8
chore(inspector): regenerate post-initialization graph snapshot
Yasir-Rafique Jul 11, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions .github/ISSUE_TEMPLATE/Bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "\U0001F41B Bug Report"
description: "If something isn't working as expected \U0001F914"
labels: ["needs triage"]
labels: ['needs triage']
type: bug
body:
- type: markdown
Expand All @@ -21,25 +21,25 @@ body:

- type: checkboxes
attributes:
label: "Is there an existing issue for this?"
description: "Please search [here](../issues?q=is%3Aissue) to see if an issue already exists for the bug you encountered"
label: 'Is there an existing issue for this?'
description: 'Please search [here](../issues?q=is%3Aissue) to see if an issue already exists for the bug you encountered'
options:
- label: "I have searched the existing issues"
required: true
- label: 'I have searched the existing issues'
required: true

- type: textarea
validations:
required: true
attributes:
label: "Current behavior"
description: "How the issue manifests?"
label: 'Current behavior'
description: 'How the issue manifests?'

- type: input
validations:
required: true
attributes:
label: "Minimum reproduction code"
placeholder: "https://github.com/..."
label: 'Minimum reproduction code'
placeholder: 'https://github.com/...'
description: |
An URL to some Git repository/[StackBlitz](https://stackblitz.com/fork/github/nestjs/typescript-starter)/[CodeSandbox](https://codesandbox.io/s/github/nestjs/typescript-starter/tree/master) project that reproduces your issue. [What is a minimum reproduction?](https://jmcdo29.github.io/wtf-is-a-minimum-reproduction)

Expand All @@ -48,7 +48,7 @@ body:

- type: textarea
attributes:
label: "Steps to reproduce"
label: 'Steps to reproduce'
description: |
How the issue manifests?
You could leave this blank if you already write this in your reproduction code
Expand All @@ -61,8 +61,8 @@ body:
validations:
required: true
attributes:
label: "Expected behavior"
description: "A clear and concise description of what you expected to happened (or code)"
label: 'Expected behavior'
description: 'A clear and concise description of what you expected to happened (or code)'

- type: markdown
attributes:
Expand All @@ -73,43 +73,43 @@ body:
validations:
required: true
attributes:
label: "Package"
label: 'Package'
description: |
Which package (or packages) do you think your issue is related to?
**Tip**: The first line of the stack trace can help you to figure out this

The package isn't listed below? Try to find its repository [here](https://github.com/orgs/nestjs/repositories) and open the issue there instead
options:
- label: "I don't know. Or some 3rd-party package"
- label: "<code>@nestjs/common</code>"
- label: "<code>@nestjs/core</code>"
- label: "<code>@nestjs/microservices</code>"
- label: "<code>@nestjs/platform-express</code>"
- label: "<code>@nestjs/platform-fastify</code>"
- label: "<code>@nestjs/platform-socket.io</code>"
- label: "<code>@nestjs/platform-ws</code>"
- label: "<code>@nestjs/testing</code>"
- label: "<code>@nestjs/websockets</code>"
- label: "Other (see below)"
- label: '<code>@nestjs/common</code>'
- label: '<code>@nestjs/core</code>'
- label: '<code>@nestjs/microservices</code>'
- label: '<code>@nestjs/platform-express</code>'
- label: '<code>@nestjs/platform-fastify</code>'
- label: '<code>@nestjs/platform-socket.io</code>'
- label: '<code>@nestjs/platform-ws</code>'
- label: '<code>@nestjs/testing</code>'
- label: '<code>@nestjs/websockets</code>'
- label: 'Other (see below)'

- type: input
attributes:
label: "Other package"
description: "If your issue is related to some package that is not listed above nor under @nestjs org, write its name here"
label: 'Other package'
description: 'If your issue is related to some package that is not listed above nor under @nestjs org, write its name here'

- type: input
attributes:
label: "NestJS version"
label: 'NestJS version'
description: |
Which version of `@nestjs/core` are you using?
**Tip**: Make sure that all of yours `@nestjs/*` dependencies are in sync!
placeholder: "8.1.3"
placeholder: '8.1.3'

- type: textarea
validations:
required: true
attributes:
label: "Packages versions"
label: 'Packages versions'
description: |
You could leave your whole `package.json` dependencies list here, or just indicate which version of `@nestjs/*` you are using
**Tip**: run _npx nest info_
Expand All @@ -120,15 +120,15 @@ body:

- type: input
attributes:
label: "Node.js version"
description: "Which version of Node.js are you using?"
placeholder: "14.17.6"
label: 'Node.js version'
description: 'Which version of Node.js are you using?'
placeholder: '14.17.6'

- type: checkboxes
validations:
required: true
attributes:
label: "In which operating systems have you tested?"
label: 'In which operating systems have you tested?'
options:
- label: macOS
- label: Windows
Expand All @@ -141,7 +141,7 @@ body:

- type: textarea
attributes:
label: "Other"
label: 'Other'
description: |
Anything else relevant? eg: Logs, OS version, IDE, package manager, etc.
**Tip:** You can attach images, recordings or log files by clicking this area to highlight it and then dragging files in
24 changes: 12 additions & 12 deletions .github/ISSUE_TEMPLATE/Feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "\U0001F680 Feature Request"
description: "I have a suggestion \U0001F63B!"
labels: ["type: enhancement :wolf:", "needs triage"]
labels: ['type: enhancement :wolf:', 'needs triage']
type: feature
body:
- type: markdown
Expand All @@ -19,18 +19,18 @@ body:

- type: checkboxes
attributes:
label: "Is there an existing issue that is already proposing this?"
description: "Please search [here](../issues?q=is%3Aissue) to see if an issue already exists for the feature you are requesting"
label: 'Is there an existing issue that is already proposing this?'
description: 'Please search [here](../issues?q=is%3Aissue) to see if an issue already exists for the feature you are requesting'
options:
- label: "I have searched the existing issues"
required: true
- label: 'I have searched the existing issues'
required: true

- type: textarea
validations:
required: true
attributes:
label: "Is your feature request related to a problem? Please describe it"
description: "A clear and concise description of what the problem is"
label: 'Is your feature request related to a problem? Please describe it'
description: 'A clear and concise description of what the problem is'
placeholder: |
I have an issue when ...

Expand All @@ -39,18 +39,18 @@ body:
required: true
attributes:
label: "Describe the solution you'd like"
description: "A clear and concise description of what you want to happen. Add any considered drawbacks"
description: 'A clear and concise description of what you want to happen. Add any considered drawbacks'

- type: textarea
validations:
required: true
attributes:
label: "Teachability, documentation, adoption, migration strategy"
description: "If you can, explain how users will be able to use this and possibly write out a version the docs. Maybe a screenshot or design?"
label: 'Teachability, documentation, adoption, migration strategy'
description: 'If you can, explain how users will be able to use this and possibly write out a version the docs. Maybe a screenshot or design?'

- type: textarea
validations:
required: true
attributes:
label: "What is the motivation / use case for changing the behavior?"
description: "Describe the motivation or the concrete use case"
label: 'What is the motivation / use case for changing the behavior?'
description: 'Describe the motivation or the concrete use case'
50 changes: 25 additions & 25 deletions .github/ISSUE_TEMPLATE/Regression.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "\U0001F4A5 Regression"
description: "Report an unexpected while upgrading your Nest application!"
labels: ["type: bug :sob:", "needs triage"]
description: 'Report an unexpected while upgrading your Nest application!'
labels: ['type: bug :sob:', 'needs triage']
type: bug
body:
- type: markdown
Expand All @@ -21,50 +21,50 @@ body:

- type: checkboxes
attributes:
label: "Did you read the migration guide?"
description: "Check out the [migration guide here](https://docs.nestjs.com/migration-guide)!"
label: 'Did you read the migration guide?'
description: 'Check out the [migration guide here](https://docs.nestjs.com/migration-guide)!'
options:
- label: "I have read the whole migration guide"
required: false
- label: 'I have read the whole migration guide'
required: false

- type: checkboxes
attributes:
label: "Is there an existing issue that is already proposing this?"
description: "Please search [here](../issues?q=is%3Aissue) to see if an issue already exists for the feature you are requesting"
label: 'Is there an existing issue that is already proposing this?'
description: 'Please search [here](../issues?q=is%3Aissue) to see if an issue already exists for the feature you are requesting'
options:
- label: "I have searched the existing issues"
required: true
- label: 'I have searched the existing issues'
required: true

- type: input
attributes:
label: "Potential Commit/PR that introduced the regression"
description: "If you have time to investigate, what PR/date/version introduced this issue"
placeholder: "PR #123 or commit 5b3c4a4"
label: 'Potential Commit/PR that introduced the regression'
description: 'If you have time to investigate, what PR/date/version introduced this issue'
placeholder: 'PR #123 or commit 5b3c4a4'

- type: input
validations:
required: true
attributes:
label: "NestJS version"
placeholder: "8.1.0 -> 8.1.3"
label: 'NestJS version'
placeholder: '8.1.0 -> 8.1.3'

- type: textarea
validations:
required: true
attributes:
label: "Describe the regression"
description: "A clear and concise description of what the regression is"
label: 'Describe the regression'
description: 'A clear and concise description of what the regression is'

- type: input
attributes:
label: "Minimum reproduction code"
description: "An URL to some git repository that reproduces this issue. [Wtf is a minimum reproduction?](https://jmcdo29.github.io/wtf-is-a-minimum-reproduction)"
placeholder: "https://github.com/..."
label: 'Minimum reproduction code'
description: 'An URL to some git repository that reproduces this issue. [Wtf is a minimum reproduction?](https://jmcdo29.github.io/wtf-is-a-minimum-reproduction)'
placeholder: 'https://github.com/...'

- type: textarea
attributes:
label: "Input code"
description: "Write some code snippets if you think it is worth it"
label: 'Input code'
description: 'Write some code snippets if you think it is worth it'
value: |
```ts

Expand All @@ -74,12 +74,12 @@ body:
validations:
required: true
attributes:
label: "Expected behavior"
description: "A clear and concise description of what you expected to happened (or code)"
label: 'Expected behavior'
description: 'A clear and concise description of what you expected to happened (or code)'

- type: textarea
attributes:
label: "Other"
label: 'Other'
description: |
Anything else relevant? eg: Logs, OS version, IDE, package manager, etc.
**Tip:** You can attach images, recordings or log files by clicking this area to highlight it and then dragging files in
29 changes: 14 additions & 15 deletions .github/ISSUE_TEMPLATE/Suggestion_improve_performance.yml
Original file line number Diff line number Diff line change
@@ -1,43 +1,43 @@
title: "perf: "
title: 'perf: '
name: "\U0001F525 Suggestion for Improving Performance"
description: "I have a suggestion that might improve the performance of Nest \U00002728"
labels: ["type: enhancement :wolf:", "needs triage"]
labels: ['type: enhancement :wolf:', 'needs triage']
type: task
body:
- type: checkboxes
attributes:
label: "Is there an existing issue that is already proposing this?"
description: "Please search [here](../issues?q=is%3Aissue) to see if an issue already exists for this"
label: 'Is there an existing issue that is already proposing this?'
description: 'Please search [here](../issues?q=is%3Aissue) to see if an issue already exists for this'
options:
- label: "I have searched the existing issues"
required: true
- label: 'I have searched the existing issues'
required: true

- type: input
validations:
required: true
attributes:
label: "NestJS version"
description: "Which version do you intend to improve?"
placeholder: "8.1.3"
label: 'NestJS version'
description: 'Which version do you intend to improve?'
placeholder: '8.1.3'

- type: textarea
attributes:
label: "Is your performance suggestion related to a problem? Please describe it"
description: "A clear and concise description of what the problem is"
label: 'Is your performance suggestion related to a problem? Please describe it'
description: 'A clear and concise description of what the problem is'

- type: textarea
validations:
required: true
attributes:
label: "Describe the performance enhancement you are proposing and how we can try it out"
label: 'Describe the performance enhancement you are proposing and how we can try it out'
placeholder: |
Cache `array.length` on the following lines ...

- type: textarea
validations:
required: true
required: true
attributes:
label: "Benchmarks result or another proof (eg: POC)"
label: 'Benchmarks result or another proof (eg: POC)'
description: |
If you've already prototyped a solution, share your results here
If not, what makes you believe there will be a performance improvement?
Expand All @@ -46,4 +46,3 @@ body:
```

MacBook Pro Mid 2014, 2.5 GHz Quad-Core Intel Core i7, 16 GB 1600 MHz DDR3, SSD

8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ blank_issues_enabled: false

contact_links:
- name: "\u2049 FAQ"
url: "https://docs.nestjs.com/faq"
about: "Make sure you have read the Frequently Asked Questions page."
url: 'https://docs.nestjs.com/faq'
about: 'Make sure you have read the Frequently Asked Questions page.'
- name: "\u2753 Discord Community of NestJS"
url: "https://discord.gg/NestJS"
about: "Please ask support questions or discuss suggestions/enhancements here."
url: 'https://discord.gg/NestJS'
about: 'Please ask support questions or discuss suggestions/enhancements here.'
Loading