feat: run all app e2e tests when configuring new sub apps#1168
Open
MitchellCash wants to merge 1 commit intonestjs:masterfrom
Open
feat: run all app e2e tests when configuring new sub apps#1168MitchellCash wants to merge 1 commit intonestjs:masterfrom
MitchellCash wants to merge 1 commit intonestjs:masterfrom
Conversation
Contributor
Author
|
I should also add - why not just make the contents of
{
"moduleFileExtensions": ["js", "json", "ts"],
"rootDir": ".",
"testEnvironment": "node",
"testRegex": ".e2e-spec.ts$",
"transform": {
"^.+\\.(t|j)s$": "ts-jest"
}
}I decided against this because I am not sure how NestJS users modify their |
When a new SubApp is added to a project the project is now configured to run all E2E tests by default. Closes nestjs#1167
df3314d to
6cac8f5
Compare
Tony133
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new SubApp is added to a project the project is now configured to run all E2E tests by default. Currently it only runs the main app E2E tests.
Closes #1167.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1167
What is the new behavior?
It will now create a new
jest-e2e.jsonfile in the./appsroot directory containing references to each sub apps E2E test configs.{ "projects": [ "apps/app-one/test/jest-e2e.json", "apps/app-two/test/jest-e2e.json", "apps/app-three/test/jest-e2e.json", "apps/app-four/test/jest-e2e.json" ] }And updating the the
test:e2eto now runjest --config apps/jest-e2e.jsonDoes this PR introduce a breaking change?
Other information
@kamilmysliwiec this differs from the open issue slightly because as I was testing on my own monorepo with 3 sub apps, the
package.jsontest:e2escript would come out rather long and not scalable:So instead I opted for a dedicated
jest-e2e.jsonthat references all the different project configs.Appreciate any and all feedback!