Vlan #27
Open
Vlan #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is clearly useful to other parts of the code, migrate ping.py while at it.
VLAN interfaces are indexed by their VLAN ID and function like normal network interfaces (as expected)
Iterate over a bunch of VLAN IDs to make sure that the switch accepts forwarding packets which are tagged.
Contributor
Author
|
Fixed the above problem by using a dictionary, thanks @d-k-c! |
d-k-c
force-pushed
the
master
branch
2 times, most recently
from
ac6b5fe to
fed2b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am seeing the following error that I don't quite understand, must be something wrong with my handling of the list indexes...:
`
DEBUG: TelnetControl: Executing: ip link del gphy.2
DEBUG: TelnetControl: Command returned 0
DEBUG: LocalControl: Executing: ip link del eth1.2
DEBUG: LocalControl: Command returned 0
DEBUG: TelnetControl: Executing: ip link del gphy.3
DEBUG: TelnetControl: Command returned 0
EE
ERROR: test_port_ping_vlan_all (tests.port.vlan.TestPingVlan)
Traceback (most recent call last):
File "/home/fainelli/dev/github/dsatest/dsatest/tests/port/vlan.py", line 39, in test_port_ping_vlan_all
host_vlan = link.host_if.vlan_interfaces[vid]
IndexError: list index out of range
======================================================================
ERROR: test_port_ping_vlan_all (tests.port.vlan.TestPingVlan)
Traceback (most recent call last):
File "/home/fainelli/dev/github/dsatest/dsatest/tests/port/vlan.py", line 30, in tearDown
link.target_if.del_vlan(vid)
File "/home/fainelli/dev/github/dsatest/dsatest/bench/interface.py", line 57, in del_vlan
self.vlan_interfaces.pop(vid)
IndexError: pop index out of range
Ran 1 test in 4.639s
FAILED (errors=2)
zsh: exit 2 sudo ./dsatest.sh -B ~/.dsatest/7278.cfg -t port_ping_vlan_all -vvv
`