feat: introduce new FrameworkId type#6834
Open
dario-piotrowicz wants to merge 1 commit intonetlify:mainfrom
Open
feat: introduce new FrameworkId type#6834dario-piotrowicz wants to merge 1 commit intonetlify:mainfrom
dario-piotrowicz wants to merge 1 commit intonetlify:mainfrom
Conversation
075a2ac to
26eefc1
Compare
26eefc1 to
56704df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's pretty minor, but as a consumer of the build-info library I think it would be pretty nice if the id of frameworks could be an actual union of the known ids instead of
string(this would help writing more type-safe code and also be more convenient for intellisense and autocompletion), so I figured I could try to open a PR to propose just that and see what y'all think 🙂.The downside here is that when someone adds (or removes) a new framework they also need to update the
FrameworkIdunion type as well, this seems pretty ok as a tradeoff to me for better type safety but up to you 🙂 (again this change is not super essential, but definitely something I'd like to take advantage of when using the library 😄)For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)