Unify system variable $basePath - PART 3 #341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inteface Nette\Application\IRouter replaced by Nette\Routing\Router
…e() for persistent parameters. [Closes nette/nette#703][Closes nette/nette#703][Closes nette#69]" (possible BC break) This reverts commit cda17f4. See https://forum.nette.org/cs/35528-stejne-pojmenovany-parametr-akce-presenteru-a-persistentni-odlisne-chovani-v-nette-2-0-oproti-aktualnimu#p221742 BC break: Property must be nullable, ie: #[Persistent] public ?int $foo
…ame>() methods (BC break)
…rs dynamically (BC break) TODO: scanDir must be active
…tion of UrlScript
This was referenced Dec 3, 2024
dg
force-pushed
the
master
branch
3 times, most recently
from
3463b9a to
ee24f8e
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
8085bc6 to
c6001b6
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
ddf16b5 to
87e4597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of nette/routing#18 + nette/http#242, where is a full description. It consists of 3 PR in 3 nette packages and all these PRs should be merged together:
nette/routing#18
nette/http#242
#341
In this PR simplifies injecting $basePath + $baseUrl into MicroPresenter + TemplateFactory using corrected $basePath from UrlScript.
I will add also a detailed description to the nette forum.