Skip to content

Fix pool matching when a server has no assigned pool#354

Open
aleclarson wants to merge 1 commit intoneumino:masterfrom
aleclarson:pool-matching
Open

Fix pool matching when a server has no assigned pool#354
aleclarson wants to merge 1 commit intoneumino:masterfrom
aleclarson:pool-matching

Conversation

@aleclarson
Copy link
Contributor

There was a missing for-loop that caused a ReferenceError to be thrown.

There was a missing for-loop that caused a ReferenceError to be thrown.
@aleclarson
Copy link
Contributor Author

aleclarson commented Oct 27, 2017

@neumino This PR should be merged ASAP.

It fixes a ReferenceError in PoolMaster.prototype.fetchServers (specifically this line where k is never defined).

@aleclarson
Copy link
Contributor Author

When I get the chance, I'll add a test that breaks without this commit.

@thelinuxlich
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants