Skip to content

Make MSE the default #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Make MSE the default #324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b74871
update default observer to be mse
shanjiaz Apr 15, 2025
9aed941
Update src/compressed_tensors/quantization/quant_args.py
shanjiaz Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/compressed_tensors/quantization/quant_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ def validate_model_after(model: "QuantizationArgs") -> Dict[str, Any]:
observer = None

elif observer is None:
# default to minmax for non-dynamic cases
observer = "minmax"
# default to mse for non-dynamic cases
observer = "mse"

# write back modified values
model.strategy = strategy
Expand Down