Skip to content

Refactor module / parameter matching logic #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Refactor module / parameter matching logic #406

wants to merge 10 commits into from

Conversation

fynnsu
Copy link

@fynnsu fynnsu commented Jul 28, 2025

Handles #405

  • expand_target_names -> replaced with match_named_modules
  • is_target -> removed
  • find_name_or_class_matches -> replaced with match_named_modules
  • _find_matches -> removed
  • get_nested_weight_mappings
  • match_param_name

@fynnsu
Small fixes
01e75b2 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
kylesayrs
kylesayrs reviewed Jul 29, 2025
View reviewed changes
fynnsu added 3 commits July 29, 2025 18:35
@fynnsu
Simplify signature of match_named_modules
d22149f 
Removed `yield_matched_targets` and `warn_on_unmatched_ignores` and updated rest of code

Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Ensure match_targets doesn't return duplicates
d94f655 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Remove preprocess_name parameter from match_named_modules
b1fa4df 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu fynnsu marked this pull request as ready for review July 29, 2025 19:48
kylesayrs
kylesayrs reviewed Jul 29, 2025
View reviewed changes
kylesayrs
kylesayrs reviewed Jul 29, 2025
View reviewed changes
@fynnsu
Restore find_name_or_class_matches as a deprecated function
70b07ec 
This function is currently used by llm-compressor so adding it back with a deprecation warning for now. 

Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
@fynnsu
Merge main into refactor_utils
074475e 
Signed-off-by: Fynn Schmitt-Ulms <[email protected]>
brian-dellabetta
brian-dellabetta reviewed Aug 7, 2025
View reviewed changes
Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! few comments

brian-dellabetta
brian-dellabetta approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylesayrs kylesayrs kylesayrs left review comments

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fynnsu @brian-dellabetta @kylesayrs