Skip to content

[Utils] Expand is_match #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kylesayrs
Copy link
Contributor

Purpose

  • Make module matching in vLLM a little cleaner

Changes

  • Change function signature of is_match to the following:
def is_match(
    name: str,
    module: torch.nn.Module,
    targets: str | Iterable[str],
    ignore: str | Iterable[str] = tuple(),
    fused: Optional[FusedMappping] = None,
)

Testing

  • Matching tests pass

Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs changed the title [Utils] [Utils] Expand is_match Aug 9, 2025
@@ -176,7 +174,8 @@ def match_modules_set(
def is_match(
name: str,
module: torch.nn.Module,
target: str,
targets: str | Iterable[str],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this rename a potential breaking change in vllm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants