Skip to content

[DEMO, do not merge] Validate #107's recipes-check on a real PR - #108

Closed
wjhrdy wants to merge 2 commits into
ci/recipes-checkfrom
demo/recipes-check-example
Closed

wjhrdy wants to merge 2 commits into
ci/recipes-checkfrom
demo/recipes-check-example

Conversation

@wjhrdy

@wjhrdy wjhrdy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Throwaway PR to validate that #107's recipes-check workflow actually fires on a real pull_request event (its own PR doesn't touch a server.yml, so the path filter never triggers there).

Deliberately touches Qwen/Qwen3.6-35B-A3B/performance/server.yml to exercise all three finding tiers the check produces:

Will push a follow-up commit reverting both once the check's output is confirmed, then close without merging (base branch ci/recipes-check still has the stale pre-#104 reasoning-parser value, so this must never land).

Local dry run confirms all three findings render correctly; this PR exists to confirm the same on GitHub Actions infra + the PR-comment step.

@github-actions

github-actions Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

vllm-project/recipes check (advisory only)

No high-confidence conflicting values found on changed models.

Other observations (performance tuning, env vars, non-blocking)
  • Qwen/Qwen3.6-35B-A3B -> Qwen/Qwen3.6-35B-A3B (match: exact)
    • enable-chunked-prefill [performance/default (hw=h100)]: ours=True vs recipe=None (extra_local)
    • gpu-memory-utilization [performance/default (hw=h100)]: ours=0.95 vs recipe=None (extra_local)
    • max-num-seqs [performance/default (hw=h100)]: ours=64 vs recipe=None (extra_local)
    • mm-encoder-tp-mode [performance/default (hw=h100)]: ours=None vs recipe='data' (missing_local)
    • enable-chunked-prefill [accuracy/default (hw=h100)]: ours=True vs recipe=None (extra_local)
    • gpu-memory-utilization [accuracy/default (hw=h100)]: ours=0.95 vs recipe=None (extra_local)
    • max-num-seqs [accuracy/default (hw=h100)]: ours=64 vs recipe=None (extra_local)
    • mm-encoder-tp-mode [accuracy/default (hw=h100)]: ours=None vs recipe='data' (missing_local)
    • upstream recipe requires vLLM >= 0.17.0

@wjhrdy

wjhrdy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Closing — validation confirmed (see comment history above). ci/recipes-check is about to be rebased onto main, which would make this branch's diff confusing to keep open.

@wjhrdy wjhrdy closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant