Repository navigation
Conversation
vllm-project/recipes check (advisory only)No high-confidence conflicting values found on changed models. Other observations (performance tuning, env vars, non-blocking)
|
Contributor
Author
|
Closing — validation confirmed (see comment history above). ci/recipes-check is about to be rebased onto main, which would make this branch's diff confusing to keep open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR to validate that #107's
recipes-checkworkflow actually fires on a realpull_requestevent (its own PR doesn't touch aserver.yml, so the path filter never triggers there).Deliberately touches
Qwen/Qwen3.6-35B-A3B/performance/server.ymlto exercise all three finding tiers the check produces:reasoning-parser: deepseek_r1(pre-existing on this branch, predates INFERENG-8300: Fix reasoning-parser and VL model attention backend for ROCm #104's fix) — high-confidence correctness difftool-call-parser: hermes(deliberately wrong) — advisory-tier diffmm-encoder-tp-modeleft unset — generic missing_local noteWill push a follow-up commit reverting both once the check's output is confirmed, then close without merging (base branch
ci/recipes-checkstill has the stale pre-#104 reasoning-parser value, so this must never land).Local dry run confirms all three findings render correctly; this PR exists to confirm the same on GitHub Actions infra + the PR-comment step.