FIX: spm.Realign compatible with recent versions of nipype #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bthirion it would be great if you tell me that you could run the examples with this patch. |
KamalakerDadi
force-pushed
the
fix_error_with_recent_nipype
branch
from
24352d7 to
2672c5f
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288
Two examples have raised problems when user have upgraded to recent Nipype version. For instance, versions > 0.13.0.
Full discussion about this issue is at NiPype tracker nipy/nipype#2406
To summarize, the problem we have seen here is with spm.Realign in particular "input specific". This PR proposes to fall back to behavior compatible to all older version input specific format when the NiPype version is recent enough i.e. > 0.13.0.
I would like to know the opinions on this please ?