Skip to content

Test import of lr_autoreduce in CI pipeline#113

Merged
backmari merged 4 commits intonextfrom
fix_import_lr_autoreduce
Jan 30, 2026
Merged

Test import of lr_autoreduce in CI pipeline#113
backmari merged 4 commits intonextfrom
fix_import_lr_autoreduce

Conversation

@backmari
Copy link
Collaborator

@backmari backmari commented Jan 29, 2026

Description of work:

Change the conda verify step to use the action conda-verify and add an extra command to check that after installing the conda package lr_reduction, one can also import the new package lr_autoreduce.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.00%. Comparing base (8d79912) to head (4745346).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #113   +/-   ##
=======================================
  Coverage   85.00%   85.00%           
=======================================
  Files          23       23           
  Lines        2841     2841           
=======================================
  Hits         2415     2415           
  Misses        426      426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@backmari backmari changed the title Fix import of lr_autoreduce Test import of lr_autoreduce in CI pipeline Jan 29, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the CI pipeline's conda package verification process by replacing a separate verification job with an integrated verification step using the neutrons/conda-verify GitHub Action. The PR also adds explicit import testing for the lr_autoreduce package and updates the pixi-build-python version constraint.

Changes:

  • Replaces the standalone conda-verify job with an integrated verification step in the build job using neutrons/conda-verify@v0.1.2 action
  • Adds import tests for lr_reduction, lr_autoreduce, and mantid packages
  • Updates pixi-build-python version constraint from 0.1.* to * in pyproject.toml

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
pyproject.toml Relaxes pixi-build-python version constraint to wildcard
pixi.lock Updates package version and removes editable flag (auto-generated)
.github/workflows/test_and_deploy.yml Consolidates package verification into build job, adds import tests, updates job dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@backmari backmari merged commit f7c256c into next Jan 30, 2026
6 checks passed
@backmari backmari deleted the fix_import_lr_autoreduce branch January 30, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants