Skip to content

Move stitching out of legacy scaling_factors/ to avoid confusion#115

Open
backmari wants to merge 1 commit intonextfrom
move_stitching_from_scaling_factors
Open

Move stitching out of legacy scaling_factors/ to avoid confusion#115
backmari wants to merge 1 commit intonextfrom
move_stitching_from_scaling_factors

Conversation

@backmari
Copy link
Collaborator

@backmari backmari commented Feb 2, 2026

Description of work:

The modules in the folder scaling_factors/ are unrelated to stitching scaling factors. To avoid confusion, move the stitching functions into a separate module stitching.py.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant