Skip to content

Comments

DeadTimeThreshold: Add log#87

Merged
1 commit merged intonextfrom
ewm8960-deadtimeThreshold-log
Oct 8, 2025
Merged

DeadTimeThreshold: Add log#87
1 commit merged intonextfrom
ewm8960-deadtimeThreshold-log

Conversation

@ghost
Copy link

@ghost ghost commented Oct 7, 2025

Description of work:

CIS requested a log for information regarding DeadTimeThreshold usage. Adds a log to show number of bins above the threshold.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@ghost ghost changed the title deadtime log DeadTimeThreshold: Add log Oct 7, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.23%. Comparing base (46b3485) to head (b6085f0).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #87      +/-   ##
==========================================
- Coverage   87.29%   87.23%   -0.07%     
==========================================
  Files          25       25              
  Lines        2865     2867       +2     
==========================================
  Hits         2501     2501              
- Misses        364      366       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ghost ghost self-assigned this Oct 7, 2025
@ghost ghost requested a review from backmari October 7, 2025 20:28
Copy link
Collaborator

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ghost ghost merged commit 9d3a31d into next Oct 8, 2025
5 checks passed
@ghost ghost deleted the ewm8960-deadtimeThreshold-log branch October 8, 2025 13:39
welbournR pushed a commit that referenced this pull request Jan 12, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants