Skip to content

Comments

Correction to Gravity Correction#88

Merged
2 commits merged intonextfrom
defect13759-gravityCorrection-sign
Oct 27, 2025
Merged

Correction to Gravity Correction#88
2 commits merged intonextfrom
defect13759-gravityCorrection-sign

Conversation

@ghost
Copy link

@ghost ghost commented Oct 27, 2025

Description of work:

CIS found that the sign of an equation is wrong, this corrects the line

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@ghost ghost self-assigned this Oct 27, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.30%. Comparing base (9d3a31d) to head (566705c).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #88      +/-   ##
==========================================
+ Coverage   87.23%   87.30%   +0.06%     
==========================================
  Files          25       25              
  Lines        2867     2867              
==========================================
+ Hits         2501     2503       +2     
+ Misses        366      364       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ghost ghost merged commit 61b7b62 into next Oct 27, 2025
5 checks passed
@ghost ghost deleted the defect13759-gravityCorrection-sign branch October 27, 2025 20:59
welbournR pushed a commit that referenced this pull request Jan 12, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants