Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #96 +/- ##
===========================================
+ Coverage 87.30% 98.98% +11.67%
===========================================
Files 25 8 -17
Lines 2883 591 -2292
===========================================
- Hits 2517 585 -1932
+ Misses 366 6 -360 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ktactac
approved these changes
Dec 4, 2025
Collaborator
ktactac
left a comment
There was a problem hiding this comment.
Reasonable structure changes and source changes to reflect that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work:
In preparation for changing the autoreduction script and adding unit tests for its functions:
src/andtests/at the top leveltmp_pathandtemplate_dirto reduce the number of hard coded paths (there are some remaining hard coded paths that make the test fail unless run from inside thetests/directory).The plan is to have:
src/lr_reduction/src/lr_autoreduction/src/lr_livereduction/However, all common functions should exist in
src/lr_reduction/and be imported from the python packagelr_reduction.Check all that apply:
References:
(Instructions for testing here)
Check list for the reviewer