Skip to content

combine data inital implementation#40

Draft
KyleQianliMa wants to merge 7 commits intonextfrom
combinedata1d
Draft

combine data inital implementation#40
KyleQianliMa wants to merge 7 commits intonextfrom
combinedata1d

Conversation

@KyleQianliMa
Copy link
Member

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 24.44444% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.05%. Comparing base (c08dc34) to head (0240b3a).
⚠️ Report is 2 commits behind head on next.

Files with missing lines Patch % Lines
src/tavi/tavi_model/combine_data.py 33.33% 18 Missing ⚠️
src/tavi/tavi_model/tavi_project.py 13.33% 13 Missing ⚠️
src/tavi/tavi_model/filter.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #40      +/-   ##
==========================================
- Coverage   77.51%   77.05%   -0.46%     
==========================================
  Files          38       39       +1     
  Lines        3754     3788      +34     
==========================================
+ Hits         2910     2919       +9     
- Misses        844      869      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants