Conversation
* reorganized project structure and removed prototype * implemented threading Signals independant of pyqt * reorganized __main__ and application startup * added singleton decorator * implemented thread worker with various signals to indicate start, finish, return * proxies no longer return any values, that defeats the point of threading
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #54 +/- ##
===========================================
+ Coverage 62.85% 82.51% +19.65%
===========================================
Files 3 6 +3
Lines 70 223 +153
===========================================
+ Hits 44 184 +140
- Misses 26 39 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
46efbd3 to
42e6b7f
Compare
7fd9a57 to
5a2a6bb
Compare
… as reformatted everything
016b134 to
b489aaa
Compare
|
I would ask that we separate out prototype code into the prototype folder or eleminate it all together if we have a fork. Also, I would prefer to see the classes have just the current implementation to this point. There is a good bit of "prototype" code and it is hard to distinguish what should be there and what should not. For instance, the threading to load files in the TaviProjectModel should not be there along with some of the attributes. It would make the review of what was actually added or changed for implementing threading much easier |
KyleQianliMa
left a comment
There was a problem hiding this comment.
I had two more comments. Let's keep the scope of the PR contained to only multithreading and proxy that should only involve the stuff in meta folder and model_response.
I'll see if I can use the singleton and proxy with the load folder gui. Then I'm happy to approve. Please also fix pre-commits. I know it's tedious but Andrei decided to enforce strict rules for tavi so let's respect that.
src/tavi/frontend/main.py
Outdated
| @@ -0,0 +1,56 @@ | |||
| """Main Qt entry point.""" | |||
There was a problem hiding this comment.
Is there a strong reason to remove this? Its just standard boilerplate.
There was a problem hiding this comment.
I can separate it out into another pr, but I still think this stuff needs to get added.
There was a problem hiding this comment.
Just to keep this pr contained. Currently there are 66 files involved for multithreading and proxy implementation. Best to do it in another pr.
| @@ -1,37 +1,40 @@ | |||
| """Entry point.""" | |||
There was a problem hiding this comment.
revert to __ main __.py in next branch. Restore "configuration.py", "configuration_template.ini", "version.py". Let's keep the scope contained only for multi-threading and proxy. So i'm only looking at "meta" folder and "model_response.py".
There was a problem hiding this comment.
of those I think I only altered version.py which really should be in the gitignore
There was a problem hiding this comment.
err, actually Im not sure why we event have a version.py? I know shiver does it that way, but otherwise I think we put it in the first __init__.py of the package, like in the template repo
There was a problem hiding this comment.
yes, my bad. I got confused looking between branches and version.py.
There was a problem hiding this comment.
In bing's original tavi I think there is a line he imported the version file. I would also do it in the next pr
sorry missed those two, they didnt show up on my local for some reason. (I did setup the percommit hook) |
…e handled through events now
Short description of the changes:
This pr implements some necessary threading changes and reorgs the project structure a little,
if I need to revert or move anything let me know, but I needed to do so to correctly test and setup threading.I have Removed the prototype code.
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References