Use different EQSANS chopper configuration depending on the experiment date#1094
Open
Use different EQSANS chopper configuration depending on the experiment date#1094
Conversation
…5th and 6th chopper logs
This comment was marked as resolved.
This comment was marked as resolved.
jmborr
requested changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work:
This PR prepares for the installation of two new choppers at EQSANS. The instrument previously had four single disk choppers (two of them paired as a double chopper), but will now have a total of single disk choppers paired as three double choppers. The chopper fixed settings (aperture, distance to source and starting phase), together with the recorded speed and phase during a run are used by
drtsansto determine the neutron wavelength bands transmitted by the choppers.drtsanswill use the logstart_timein the NeXus file to determine whether to calculate the wavelength bands using the old four chopper configuration or the new six chopper configuration.There is a follow up story to update the configuration values after they have been determined by the IS, and to add testing with real data using the new choppers:
Story 15020: [drtsans] Update EQSANS chopper configuration values after choppers have been installed.
Check all that apply:
References:
Check list for the reviewer
Execution of tests requiring the /SNS and /HFIR filesystems
It is strongly encouraged that the reviewer runs the following tests in their local machine
because these tests are not run by the GitLab CI. It is assumed that the reviewer has the /SNS and /HFIR filesystems
remotely mounted in their machine.
In the above code snippet, substitute
<MERGE_REQUEST_NUMBER>for the actual merge request number. Also substitute<my_drtsans_dev_environment>with the name of the conda environment you use for development. It is critical thatyou have installed the repo in this conda environment in editable mode with
pip install -e .orconda develop .