Improve building of RPMs - #63
Closed
peterfpeterson wants to merge 9 commits into
Closed
Conversation
peterfpeterson
marked this pull request as ready for review
September 25, 2025 14:39
darshdinger
reviewed
Sep 25, 2025
| toml set tool.pixi.package.version "${VERSION}" --toml-path pyproject.toml | ||
| # remove all the things that reference dynamic versions | ||
| toml unset project.dynamic --toml-path pyproject.toml | ||
| toml set project.version "${VERSION}" --toml-path pyproject.toml |
Contributor
There was a problem hiding this comment.
Is this line redundant? Isn't this being set twice? Once here and once in line 8 above? So can this be removed?
Member
Author
There was a problem hiding this comment.
They are two different parts of the pyproject.toml. For whatever reason, the package.version and project.version are completely independent.
peterfpeterson
force-pushed
the
rpmbuild_ci
branch
from
September 26, 2025 17:12
0d1456f to
5b26bce
Compare
peterfpeterson
force-pushed
the
rpmbuild_ci
branch
from
September 26, 2025 18:35
5b26bce to
d65703e
Compare
Member
Author
|
This is being redone in #67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to add a job to build the rpm in CI, it was discovered that
rpmbuild.shwas partially repeating the work from thesync-versiontask in pixi. This refactors the code for clearing out things from thepyproject.tomland adds the version for the rpm to be an environment variable that is injected in.There are also some small changes to pull in newer versions of pixi tasks from the python-project-template.
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
Check out the code on some place that can build rpms and run
./rpmbuild.shthen follow the instructions from the script to validate the rpm makes sense.References
EWM13162