Conversation
mbruin-NR
commented
Jul 16, 2026
Contributor
- _Atomic(int) _cachedStatus ivar — lock-free cache for the last known status. int rather than the enum directly to avoid any C11 _Atomic-on-enum edge cases.
- NRMAReachabilityCallback + setup in +reachability — one synchronous SCNetworkReachabilityGetFlags call at creation time primes the cache, thenSCNetworkReachabilitySetDispatchQueue hands off all future updates to a utility queue. After this, no thread ever blocks on reachability.
- dealloc — cancels the callback and queue before CFRelease. This is the critical safety pairing:text (non-owning) is safe only because dealloc guarantees no callback fires after the object is freed.
- CurrentReachabilityStatus that checkOfflineStatus called on every event no longer touches the Network framework.
… of calling it every time
diegomtz5
approved these changes
Jul 16, 2026
cdillard-NewRelic
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.