Skip to content

chore: Added workflows to generate a config schema and version before agent release - #4161

Merged
bizob2828 merged 15 commits into
newrelic:mainfrom
mvicknr:mvick/add-agent-config-schema
Aug 19, 2026
Merged

chore: Added workflows to generate a config schema and version before agent release#4161
bizob2828 merged 15 commits into
newrelic:mainfrom
mvicknr:mvick/add-agent-config-schema

Conversation

@mvicknr

@mvicknr mvicknr commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a script to automatically generate and update a configuration schema for the agent. This PR has the initial schema generated from the script.

The script will automatically run on local pre-commit and on pushes (except main). It will determine if there are config changes and if so, it will update the schema.O n local, the dev should include these changes in their commit. In the PR build, if the changes aren't already made in the schema, it will make the changes and add them to the PR.

The schema version will be updated during the release process.

I split the work into commits so you can review in chunks

How to Test

Unit tests provided. GH workflows run locally with act

Related Issues

N/A

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (ff0496e) to head (5c681b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4161      +/-   ##
==========================================
- Coverage   97.52%   97.44%   -0.09%     
==========================================
  Files         521      521              
  Lines       63010    63026      +16     
  Branches        1        1              
==========================================
- Hits        61450    61415      -35     
- Misses       1560     1611      +51     
Flag Coverage Δ
integration-tests-cjs-22.x 73.66% <100.00%> (+<0.01%) ⬆️
integration-tests-cjs-24.x 74.24% <100.00%> (+<0.01%) ⬆️
integration-tests-cjs-26.x 74.24% <100.00%> (+<0.01%) ⬆️
integration-tests-esm-22.x 54.63% <100.00%> (+0.01%) ⬆️
integration-tests-esm-24.x 55.93% <100.00%> (+0.01%) ⬆️
integration-tests-esm-26.x 55.93% <100.00%> (+0.01%) ⬆️
unit-tests-22.x 89.16% <100.00%> (+<0.01%) ⬆️
unit-tests-24.x 89.11% <100.00%> (+<0.01%) ⬆️
unit-tests-26.x 89.11% <100.00%> (+<0.01%) ⬆️
versioned-tests-22.x 97.44% <100.00%> (-0.09%) ⬇️
versioned-tests-24.x 97.44% <100.00%> (-0.09%) ⬇️
versioned-tests-26.x 97.44% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mvicknr mvicknr changed the title chore: Add initial generator and schema chore: Initial work to add agent config schema Jul 22, 2026
Comment thread .fleetControl/schemas/config.json
Comment thread .fleetControl/schemas/config.json Outdated
Comment thread .github/workflows/agent-config-schema-bump.yml Outdated
@mvicknr
mvicknr marked this pull request as ready for review July 22, 2026 20:32
Comment thread package.json Outdated

@bizob2828 bizob2828 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're really hands off on this. I trust @mvicknr that she verified that this will fit her needs. There's a merge conflict but LGTM

Comment thread package.json
Comment thread bin/update-config-schema.sh Outdated
Comment thread .fleetControl/schemas/config.json
Comment thread .github/workflows/agent-config-schema.yml

@bizob2828 bizob2828 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i decided to dig more into this. a few comments/suggestions

@bizob2828 bizob2828 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments from discussion in google meet

Comment thread package.json
Comment thread .github/workflows/agent-config-schema-bump.yml Outdated
Comment thread .github/workflows/agent-config-schema.yml Outdated
Comment thread .lintstagedrc.json Outdated
Comment thread .fleetControl/schemaGeneration/generate-schema.js Outdated
Comment thread .github/workflows/agent-config-schema.yml Outdated

@bizob2828 bizob2828 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions. getting close though, nice work!

Comment thread .github/workflows/agent-config-schema-bump.yml Outdated
Comment thread .github/workflows/agent-config-schema.yml Outdated
Comment thread .github/workflows/prep-release.yml Outdated
Comment thread .github/workflows/prepare-release.yml Outdated
bizob2828
bizob2828 previously approved these changes Aug 19, 2026

@bizob2828 bizob2828 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small tweak but don't sweat it. i can handle this later. I'm approving but I have to see from team when to land this because we know we may have issues.

Comment thread .github/workflows/agent-config-schema.yml Outdated
@bizob2828 bizob2828 changed the title chore: Initial work to add agent config schema chore: Added workflows to generate a config schema and version before agent release Aug 19, 2026
mvicknr and others added 12 commits August 19, 2026 13:14
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Github Copilot <github.copilot@ai.newrelic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
mvicknr and others added 2 commits August 19, 2026 13:14
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@bizob2828
bizob2828 force-pushed the mvick/add-agent-config-schema branch from fe4e399 to 8f838e6 Compare August 19, 2026 17:15
@bizob2828
bizob2828 merged commit 56987ca into newrelic:main Aug 19, 2026
55 of 56 checks passed
@github-project-automation github-project-automation Bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Aug 19, 2026
This was referenced Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done: Issues recently completed

Development

Successfully merging this pull request may close these issues.

3 participants