refactor: Refactored dns instrumentation to subscribe to events emitted - #4224
Draft
bizob2828 wants to merge 2 commits into
Draft
refactor: Refactored dns instrumentation to subscribe to events emitted#4224bizob2828 wants to merge 2 commits into
dns instrumentation to subscribe to events emitted#4224bizob2828 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4224 +/- ##
==========================================
- Coverage 97.52% 97.45% -0.08%
==========================================
Files 522 526 +4
Lines 62949 63234 +285
Branches 1 1
==========================================
+ Hits 61390 61622 +232
- Misses 1559 1612 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jsumners-nr
reviewed
Aug 13, 2026
| ...require('./subscribers/bunyan/config'), | ||
| ...require('./subscribers/cassandra-driver/config'), | ||
| ...require('./subscribers/connect/config'), | ||
| ...require('./subscribers/dns/config'), |
Contributor
There was a problem hiding this comment.
We don't want?: ./subscribers/core/dns/config?
Member
Author
There was a problem hiding this comment.
i guess we could because my next commit will have some sort of abstraction for core library instrumentation so i can live there as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP. I want to refactor some subscriber work but just posting to show differences from #4212