Skip to content

[DRAFT] feat(NcPopover): add fullscreen mobile mode #6597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: stable8
Choose a base branch
from
Draft

[DRAFT] feat(NcPopover): add fullscreen mobile mode #6597

wants to merge 1 commit into from
+74 −21

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 6, 2025

☑️ Resolves

  • Add classic mobile menu mode for NcPopover
    • Optional
    • Enabled for NcActions by default

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added enhancement New feature or request 2. developing Work in progress feature: popover Related to the popovermenu component feature: actions Related to the actions components design Design, UX, interface and interaction design labels Mar 6, 2025
@ShGKme ShGKme added this to the 8.24.0 milestone Mar 6, 2025
@ShGKme ShGKme requested a review from marcoambrosini March 6, 2025 19:46
@ShGKme ShGKme self-assigned this Mar 6, 2025
marcoambrosini
marcoambrosini approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @ShGKme !

@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 21, 2025

@marcoambrosini Do you think it looks fine, of we should increase the size of action items on mobile?

@marcoambrosini
Copy link
Contributor

Let's try it like this, but maybe in the future it would be wise to have the --clickable-area variable return a slightly bigger value on mobile

@ShGKme ShGKme requested a review from susnux March 25, 2025 22:17
@ShGKme ShGKme modified the milestones: 8.24.0, 8.25.0 Apr 2, 2025
@susnux susnux modified the milestones: 8.25.0, 8.26.0 Apr 16, 2025
@susnux susnux removed this from the 8.26.0 milestone Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees

@ShGKme ShGKme

Labels
2. developing Work in progress design Design, UX, interface and interaction design enhancement New feature or request feature: actions Related to the actions components feature: popover Related to the popovermenu component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @marcoambrosini @susnux